From: Ben Hutchings Date: Thu, 1 Dec 2016 23:13:38 +0000 (+0000) Subject: Revert "s390: move exports to definitions" X-Git-Tag: archive/raspbian/4.9.13-1+rpi1~11^2~29 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=8505f2ca0bec4265e129afa26f7d5f1a9aece5b8;p=linux-4.9.git Revert "s390: move exports to definitions" This reverts commit 711f5df7bf3ae7657e15edf76d671042c051ce95 because symbols exported from assembly don't automatically get modversions (ABI hashes). Gbp-Pq: Topic bugfix/s390 Gbp-Pq: Name revert-s390-move-exports-to-definitions.patch --- diff --git a/arch/s390/include/asm/Kbuild b/arch/s390/include/asm/Kbuild index 20f196b82a6e..9043d2e1e2ae 100644 --- a/arch/s390/include/asm/Kbuild +++ b/arch/s390/include/asm/Kbuild @@ -1,7 +1,6 @@ generic-y += clkdev.h -generic-y += export.h generic-y += irq_work.h generic-y += mcs_spinlock.h generic-y += mm-arch-hooks.h diff --git a/arch/s390/kernel/Makefile b/arch/s390/kernel/Makefile index 1f0fe98f6db9..72ccc41444dc 100644 --- a/arch/s390/kernel/Makefile +++ b/arch/s390/kernel/Makefile @@ -61,7 +61,7 @@ obj-y += entry.o reipl.o relocate_kernel.o extra-y += head.o head64.o vmlinux.lds -obj-$(CONFIG_MODULES) += module.o +obj-$(CONFIG_MODULES) += s390_ksyms.o module.o obj-$(CONFIG_SMP) += smp.o obj-$(CONFIG_SCHED_TOPOLOGY) += topology.o obj-$(CONFIG_HIBERNATION) += suspend.o swsusp.o diff --git a/arch/s390/kernel/entry.S b/arch/s390/kernel/entry.S index 49a30737adde..c51650a1ed16 100644 --- a/arch/s390/kernel/entry.S +++ b/arch/s390/kernel/entry.S @@ -23,7 +23,6 @@ #include #include #include -#include __PT_R0 = __PT_GPRS __PT_R1 = __PT_GPRS + 8 @@ -260,8 +259,6 @@ sie_exit: EX_TABLE(.Lrewind_pad,.Lsie_fault) EX_TABLE(sie_exit,.Lsie_fault) -EXPORT_SYMBOL(sie64a) -EXPORT_SYMBOL(sie_exit) #endif /* @@ -828,9 +825,6 @@ ENTRY(save_fpu_regs) oi __LC_CPU_FLAGS+7,_CIF_FPU br %r14 .Lsave_fpu_regs_end: -#if IS_ENABLED(CONFIG_KVM) -EXPORT_SYMBOL(save_fpu_regs) -#endif /* * Load floating-point controls and floating-point or vector registers. diff --git a/arch/s390/kernel/mcount.S b/arch/s390/kernel/mcount.S index 9a17e4475d27..e499370fbccb 100644 --- a/arch/s390/kernel/mcount.S +++ b/arch/s390/kernel/mcount.S @@ -9,7 +9,6 @@ #include #include #include -#include .section .kprobes.text, "ax" @@ -24,8 +23,6 @@ ENTRY(ftrace_stub) ENTRY(_mcount) br %r14 -EXPORT_SYMBOL(_mcount) - ENTRY(ftrace_caller) .globl ftrace_regs_caller .set ftrace_regs_caller,ftrace_caller diff --git a/arch/s390/kernel/s390_ksyms.c b/arch/s390/kernel/s390_ksyms.c new file mode 100644 index 000000000000..e67453b73c3c --- /dev/null +++ b/arch/s390/kernel/s390_ksyms.c @@ -0,0 +1,15 @@ +#include +#include +#include +#include + +#ifdef CONFIG_FUNCTION_TRACER +EXPORT_SYMBOL(_mcount); +#endif +#if IS_ENABLED(CONFIG_KVM) +EXPORT_SYMBOL(sie64a); +EXPORT_SYMBOL(sie_exit); +EXPORT_SYMBOL(save_fpu_regs); +#endif +EXPORT_SYMBOL(memcpy); +EXPORT_SYMBOL(memset); diff --git a/arch/s390/lib/mem.S b/arch/s390/lib/mem.S index be9fa65bfac4..c6d553e85ab1 100644 --- a/arch/s390/lib/mem.S +++ b/arch/s390/lib/mem.S @@ -5,7 +5,6 @@ */ #include -#include /* * memset implementation @@ -61,7 +60,6 @@ ENTRY(memset) xc 0(1,%r1),0(%r1) .Lmemset_mvc: mvc 1(1,%r1),0(%r1) -EXPORT_SYMBOL(memset) /* * memcpy implementation @@ -88,4 +86,3 @@ ENTRY(memcpy) j .Lmemcpy_rest .Lmemcpy_mvc: mvc 0(1,%r1),0(%r3) -EXPORT_SYMBOL(memcpy)